Fix mp44

Ashaz

Thx to mattlawn for reminding me about this

this is not an important bug but /mp44 is broken, it's just an entertainment feature of TFM so nothing big. Would be nice to have it working again.

videogamesm12

How is it broken? You can't just say "it's broken" and expect the developers to understand.

Ashaz

videogamesm12 it just doesnt work at all

DragonSlayer2189

videogamesm12 theres no way to tell how its broken because it is disabled

Ashaz

DragonSlayer2189 ask an admin to toggle it on

Fleek

For us to be able to work effectively, please include the steps to reproduce this issue - just saying it's broken doesn't help (just like what @videogamesm12 said), we need more explanation like does it produce error in the console, is it enabled when you test it and what is the expected outcome?

Once I have more information, I will raise a ticket to investigate.

redeastwood

Fleek Running the command /mp44 returns the text "mp44 is currently disabled". This thread is misleading, the command isn’t broken just disabled.

Fleek

redeastwood Then it's disabled in configuration - see https://github.com/AtlasMediaGroup/TotalFreedomMod/blob/development/src/main/java/me/totalfreedom/totalfreedommod/command/Command_mp44.java#L22

To enable it, run /toggle mp44

Ashaz

redeastwood

thats why I told dragon to get an admin to toggle it

I apologise for the delay @Fleek, it was late and I should have posted the thread today instead.

anyway:
to reproduce:
1) /toggle mp44
2) /mp44
you get given a gunpowder but it won't work and thats the issue

Fleek

Had some spare time so I decided to check it out myself, it produces an NPE error in the console whenever you use it. I have raised FS-159 on Jira to fix this.

jjjaguar2000

Ashaz
It was most likely disabled with intention of fixing it and must have just been overlooked. This command is actually an original TFM feature, added by Madgeek.

StevenNL2000

JagWire I do recall old admins saying that it was disabled because it was broken. It has been continuously disabled for at least 5 years.

Fleek

Can this thread be marked as approved and locked?